Skip to content
This repository has been archived by the owner on Jan 19, 2021. It is now read-only.

Feature/token auth use environment #2355

Closed
wants to merge 1 commit into from
Closed

Feature/token auth use environment #2355

wants to merge 1 commit into from

Conversation

gobigfoot
Copy link

Before creating a pull request, make sure that you have read the contribution file located at

https://github.com/SharePoint/PnP-PowerShell/blob/dev/CONTRIBUTING.md

Type

  • Bug Fix
  • New Feature
  • Sample

Related Issues?

Fixes #2352
Fixes #2302

What is in this Pull Request ?

Enables App Only (Token) authentication to use AzureEnvironment endpoints.
IAW Example 8 in the Connect-PnPOnline documentation. Verified using USGovernment GCC High and Production Tenants.

@gobigfoot gobigfoot changed the base branch from master to dev November 13, 2019 18:37
@KoenZomers
Copy link
Collaborator

Hi @gobigfoot. Thanks for your contribution! As I don't have access to a GCC environment to validate this, can you elaborate if the change you're proposing here has dependencies on the PR(s) you have done in PnP Sites Core?

@gobigfoot
Copy link
Author

This change does depend on the change made in core. The Microsoft team changed the authentication endpoints as documented https://devblogs.microsoft.com/azuregov/azure-government-aad-authority-endpoint-update/ . This change passes along the environment to hit the correct authentication endpoint.

@gobigfoot
Copy link
Author

It should correct the issue in all of the sovereign clouds, but I'm unable to verify as I only have access to GCC and Production tenants.

@KoenZomers
Copy link
Collaborator

Roger that, so just to double triple check, all changes your PR requires are already in the currently published PnP Sites Core version, correct?

@gobigfoot
Copy link
Author

@KoenZomers Yes, the core changes are released.

This was referenced Jan 22, 2020
@KoenZomers
Copy link
Collaborator

Thanks for your contribution. Merging it through PR #2465

@KoenZomers KoenZomers closed this Jan 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants