Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle size: decrease the bundle size for latest version of SPFx #136

Closed
estruyf opened this issue Sep 19, 2018 · 2 comments
Closed

Bundle size: decrease the bundle size for latest version of SPFx #136

estruyf opened this issue Sep 19, 2018 · 2 comments
Milestone

Comments

@estruyf
Copy link
Member

estruyf commented Sep 19, 2018

Category

[x] Enhancement
[ ] Bug
[ ] Question

Version

Please specify what version of the library you are using: [latest]

Expected / Desired Behavior / Question

Let the controls use the same version as the latest SPFx version uses. For example, SPFx 1.6.0 uses version 5.120.0 of Office UI Fabric. By using the same version, the bundle sizes can be decreased.

estruyf added a commit that referenced this issue Sep 19, 2018
@estruyf estruyf added this to the 1.9.0 milestone Sep 19, 2018
@estruyf
Copy link
Member Author

estruyf commented Sep 21, 2018

This will be available today in version 1.9.0.

@estruyf estruyf closed this as completed Sep 21, 2018
@wobba
Copy link
Contributor

wobba commented Nov 9, 2018

@estruyf will you bump to match SPFx v1.7? As long as we use ouifr v5, you could enter deps to something like «>=5.120.0 <6.0.0», and then the consuming SPFx can set exactly which one they use. I known ouifr uses semver, and hard to see what changes on middle number version. But have yet to see it break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants