Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ListPicker add ability to filter the control in other ways #319

Closed
araver opened this issue May 31, 2019 · 6 comments

Comments

@araver
Copy link

commented May 31, 2019

Category

[X] Enhancement

[ ] Bug

[ ] Question

Version

Please specify what version of the library you are using: [1.13.1]

Expected / Desired Behavior / Question

Ability to filter list using something other than list template

I think it would be nice to have a promise like callback that would allow the developer to filter, or possibly a filter string that could be sent on the "GET" request or both.

@msftbot

This comment has been minimized.

Copy link

commented May 31, 2019

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@gitbrent

This comment has been minimized.

Copy link

commented Jun 20, 2019

I second this request.

Adding a new property that would allow filtering the list using an OData query (e.g.: Active_x003f_ eq true) would greatly benefit this component as returning all items is not always desired.

I'd be willing to provide a PR to add a new filter property and any other work required.

@araver

This comment has been minimized.

Copy link
Author

commented Jun 21, 2019

@gitbrent I've created a PR in the property pane controls. I can copy the changes over to this project or if you'd like to, you can duplicate the changes. PR 189

estruyf added a commit that referenced this issue Jul 9, 2019

@estruyf estruyf added this to the 1.14.0 milestone Jul 9, 2019

@estruyf

This comment has been minimized.

Copy link
Collaborator

commented Jul 9, 2019

This has now been copied over from the control project and will be available in version 1.14.0. Please feel free to test out the latest beta to see if it fits your needs. More information about how you can test out a beta version can be found here: https://sharepoint.github.io/sp-dev-fx-controls-react/beta/

@gitbrent

This comment has been minimized.

Copy link

commented Jul 11, 2019

Thanks @estruyf - this is precisely what I had envisioned.

@estruyf

This comment has been minimized.

Copy link
Collaborator

commented Jul 18, 2019

This is now included within the 1.14.0 release

@estruyf estruyf closed this Jul 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.