Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
IFrameDialog "commitPopUp" typo causes popups with classic forms to not close after hitting save #433
[ ] Enhancement
[ ] Question
Please specify what version of the library you are using: [ 1.15.0 ]
Expected / Desired Behavior / Question
When using the IFrameDialog control to render classic forms in a popup in SharePoint Online, the dialog popup should close after hitting Save or Cancel.
After the iframe is rendered containing the classic form, hitting Cancel triggers the event and the popup closes as expected. However, after hitting Save the event is not triggered and the popup remains open and the classic list view is shown.
After searching high and low for why cancel was working and save was not, I noticed that SharePoint uses different casings of "popup" for the commit and the cancel events.
The cancel function used in SharePoint is:
The commit function is:
Steps to Reproduce
-- Create an SPFx solution that renders a classic form in a popup dialog using the IFrameDialog control