Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FieldUserRenderer uses email prop for GetPropertiesFor #84

Closed
phettz opened this issue Jun 14, 2018 · 4 comments
Closed

FieldUserRenderer uses email prop for GetPropertiesFor #84

phettz opened this issue Jun 14, 2018 · 4 comments
Milestone

Comments

@phettz
Copy link

phettz commented Jun 14, 2018

Category
[ ] Enhancement
[x] Bug
[ ] Question

Version
Please specify what version of the library you are using: [1.4.0]

Expected / Desired Behavior / Question
The FieldUserRenderer uses the email property in _requestUserProfile for GetPropertiesFor. Now that works in most cases, but I have encountered some customer where email and account name is not the same. Then I have to send in the account name as email to get it to work.

https://github.com/SharePoint/sp-dev-fx-controls-react/blob/05d6045173360be4712b712abb8c65e455c269a8/src/controls/fields/fieldUserRenderer/FieldUserRenderer.tsx#L249

@estruyf estruyf added the bug label Jun 14, 2018
@estruyf estruyf assigned estruyf and unassigned estruyf Jun 14, 2018
@estruyf
Copy link
Member

estruyf commented Jun 14, 2018

@phettz thank you for reporting this.

@AJIXuMuK can you pick this one?

@AJIXuMuK
Copy link
Collaborator

Hi @estruyf,
Yup, I'll be looking into it.

@phettz could you please provide a bit more details? Is that external user or some non standard way of AD sync? I want to reproduce it first if possible.

@phettz
Copy link
Author

phettz commented Jun 14, 2018

@AJIXuMuK to be fair, its probably not much you can do at the moment when I'm thinking about it, since the IFieldCustomizerCellEventParameters for Person fields only returns email, id, picture, sip and title props. It is users from AD, I have no idea why they have done it like that, probably have some reasons for it.

I don't know, maybe add another property for <FieldUserRenderer users={event.fieldValue} context={this.context} useUserId={true} ... or somehting and then to another rest query to get the account name before calling the GetPropertiesFor

@AJIXuMuK
Copy link
Collaborator

Created a PR #85 to fix the issue.

estruyf added a commit that referenced this issue Jun 15, 2018
@estruyf estruyf added this to the 1.5.0 milestone Jun 15, 2018
@estruyf estruyf closed this as completed Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants