Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ListView.md: iconFieldName description #245

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@PzKfWg
Copy link
Contributor

commented Feb 28, 2019

I had a hard time understanding how to use iconFieldName and its effect. It was not clear to me by the original description that it required the property name of the items with the path of the file and that it would automagically create the entire column, header and field rendering. I had to read the source code to figure it out.

What's in this Pull Request?

Added precision to the iconFieldName property implementation

Related to issue #190

Update ListView.md: iconFieldName description
I had a hard time understanding how to use iconFieldName and its effect. It was not clear to me by the original description that it required the property name of the items with the path of the file and that it would automagically create the entire column, header and field rendering. I had to read the source code to figure it out.
@codecov-io

This comment has been minimized.

Copy link

commented Feb 28, 2019

Codecov Report

Merging #245 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #245   +/-   ##
=======================================
  Coverage   72.71%   72.71%           
=======================================
  Files          16       16           
  Lines         744      744           
  Branches      148      148           
=======================================
  Hits          541      541           
  Misses        159      159           
  Partials       44       44

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c4c2e4...398a6c8. Read the comment docs.

@estruyf

This comment has been minimized.

Copy link
Collaborator

commented Mar 29, 2019

Thank you very much @PzKfWg for the documentation update. I have merged this into the DEV branch.

@estruyf estruyf closed this Mar 29, 2019

@estruyf estruyf added this to the 1.13.0 milestone Mar 29, 2019

@estruyf estruyf referenced this pull request Apr 24, 2019

Merged

Merge for 1.13.0 #278

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.