Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TaxonomyPicker: Save and cancel buttons are not translated #361

Closed
robert-lindstrom opened this issue Aug 28, 2019 · 2 comments
Closed

TaxonomyPicker: Save and cancel buttons are not translated #361

robert-lindstrom opened this issue Aug 28, 2019 · 2 comments
Labels
type:enhancement New feature or enhancement of existing capability
Milestone
1.15.0

Comments

@robert-lindstrom
Copy link
Contributor

Category

[ ] Enhancement

[x] Bug

[ ] Question

Version

Please specify what version of the library you are using: [latest]

Expected / Desired Behavior / Question

The TaxonomyPicker control opens a panel for selecting terms. At the bottom of this panel are two buttons, Save and Cancel. The labels of these buttons are not translated.
Expect button labels to be translated for supported languages, e.g. German where labels should be 'Speichern' and 'Abbrechen' respectively.

Observed Behavior

Labels are always 'Save' and 'Cancel' regardless of browser language

Steps to Reproduce

Use TaxonomyPicker with browser language set to another supported language (e.g. German).
@ghost
Copy link

ghost commented Aug 28, 2019

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Aug 28, 2019
@robert-lindstrom robert-lindstrom mentioned this issue Aug 28, 2019
Merged
@estruyf estruyf added this to the 1.15.0 milestone Sep 3, 2019
@estruyf estruyf added type:enhancement New feature or enhancement of existing capability and removed Needs: Triage 🔍 labels Sep 3, 2019
@AJIXuMuK AJIXuMuK mentioned this issue Oct 9, 2019
Closed
@estruyf estruyf mentioned this issue Oct 14, 2019
Merged
@estruyf
Copy link
Member

estruyf commented Oct 14, 2019

Closing this issue as version 1.15.0 has just been released.

@estruyf estruyf closed this as completed Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:enhancement New feature or enhancement of existing capability
Projects
None yet
Milestone
1.15.0
Development

No branches or pull requests
2 participants
@estruyf @robert-lindstrom