Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placeholder: remove unused and vendor specific CSS #426

Merged

Conversation

@dmitryrogozhny
Copy link
Contributor

dmitryrogozhny commented Dec 5, 2019

Q A
Bug fix? [x]
New feature? [ ]
New sample? [ ]
Related issues? fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?

A small enhancement to Placeholder control styles to make the code a bit cleaner:

  • Removed .placeholderOverlay and .placeholderSpinnerContainer styles which are not being referenced anywhere in the code.
  • Removed vendor specific styles, such as display: -webkit-box; as they got automatically created by SPFx build process.

As for vendor prefixed styles properties, excerpt from the Recommendations for working with CSS in SharePoint Framework solutions article:

In SharePoint Framework, no vendor prefixed style properties are required in the Sass or CSS files of a project. If some of the SharePoint Framework-supported browsers require prefixes, they were added after the Sass to CSS compilation automatically.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 5, 2019

Codecov Report

Merging #426 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #426   +/-   ##
=======================================
  Coverage   73.31%   73.31%           
=======================================
  Files          18       18           
  Lines         802      802           
  Branches      164      154   -10     
=======================================
  Hits          588      588           
  Misses        164      164           
  Partials       50       50

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a66b915...3b4cefe. Read the comment docs.

@AJIXuMuK AJIXuMuK merged commit 09e0664 into SharePoint:dev Dec 6, 2019
3 checks passed
3 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
license/cla All CLA requirements met.
Details
@AJIXuMuK

This comment has been minimized.

Copy link
Collaborator

AJIXuMuK commented Dec 6, 2019

Thank you @dmitryrogozhny for the update!

@estruyf estruyf mentioned this pull request Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.