Updated js-command-clone to 1.4

pnp · Jan 20, 2018 · 351195d · 351195d
1 parent 9780eb5
commit 351195d
Show file tree

Hide file tree

Showing 10 changed files with 179 additions and 191 deletions.
diff --git a/samples/js-command-clone/.yo-rc.json b/samples/js-command-clone/.yo-rc.json
@@ -1,6 +1,6 @@
 {
   "@microsoft/generator-sharepoint": {
-    "version": "1.3.0",
+    "version": "1.4.0",
     "libraryName": "js-command-clone",
     "libraryId": "ede39249-4139-4af6-8fe0-1d480bd1f6c6",
     "environment": "spo"

diff --git a/samples/js-command-clone/README.md b/samples/js-command-clone/README.md
@@ -6,7 +6,7 @@ Sample SharePoint Framework listview command set extension that allows users to
 ![Cloning of list items](./assets/spfxClone-Animation.gif)
 
 ## Used SharePoint Framework Version 
-![1.3.0](https://img.shields.io/badge/version-1.3.0-green.svg)
+![1.4.0](https://img.shields.io/badge/version-1.3.0-green.svg)
 
 ## Applies to
 
@@ -26,6 +26,7 @@ Version|Date|Comments
 -------|----|--------
 1.0|August 30, 2017|Initial release
 1.1|September 26, 2017|Updated for SPFx Extensions GA 1.3.0
+1.2|January 20, 2018|Updated for SPFx 1.4.0
 
 ## Disclaimer
 **THIS CODE IS PROVIDED *AS IS* WITHOUT WARRANTY OF ANY KIND, EITHER EXPRESS OR IMPLIED, INCLUDING ANY IMPLIED WARRANTIES OF FITNESS FOR A PARTICULAR PURPOSE, MERCHANTABILITY, OR NON-INFRINGEMENT.**

diff --git a/samples/js-command-clone/assets/CommandIcon.png b/samples/js-command-clone/assets/CommandIcon.png
diff --git a/samples/js-command-clone/config/config.json b/samples/js-command-clone/config/config.json
@@ -12,7 +12,7 @@
     }
   },
   "externals": {
-    "sp-pnp-js": "https://cdnjs.cloudflare.com/ajax/libs/sp-pnp-js/3.0.1/pnp.min.js"
+    "sp-pnp-js": "https://cdnjs.cloudflare.com/ajax/libs/sp-pnp-js/3.0.4/pnp.min.js"
   },
   "localizedResources": {
     "SpfxCloneCommandSetStrings": "lib/extensions/spfxClone/loc/{locale}.js"

diff --git a/samples/js-command-clone/config/package-solution.json b/samples/js-command-clone/config/package-solution.json
@@ -4,6 +4,7 @@
     "name": "js-command-clone-client-side-solution",
     "id": "ede39249-4139-4af6-8fe0-1d480bd1f6c6",
     "version": "1.0.0.0",
+    "includeClientSideAssets": true,
     "skipFeatureDeployment": true,
     "iconPath": "AppIcon.png"
   },

diff --git a/samples/js-command-clone/gulpfile.js b/samples/js-command-clone/gulpfile.js
@@ -2,5 +2,6 @@
 
 const gulp = require('gulp');
 const build = require('@microsoft/sp-build-web');
+build.addSuppression(`Warning - [sass] The local CSS class 'ms-Grid' is not camelCase and will not be type-safe.`);
 
 build.initialize(gulp);
diff --git a/samples/js-command-clone/npm-shrinkwrap.json b/samples/js-command-clone/npm-shrinkwrap.json
diff --git a/samples/js-command-clone/package.json b/samples/js-command-clone/package.json
@@ -11,19 +11,20 @@
     "test": "gulp test"
   },
   "dependencies": {
-    "@microsoft/sp-core-library": "~1.3.0",
-    "@microsoft/decorators": "~1.3.0",
+    "@microsoft/sp-core-library": "~1.4.0",
+    "@microsoft/decorators": "~1.4.0",
     "@types/webpack-env": ">=1.12.1 <1.14.0",
-    "@microsoft/sp-listview-extensibility": "1.3.0",
-    "@microsoft/sp-dialog": "1.3.0"
+    "@microsoft/sp-listview-extensibility": "~1.4.0",
+    "@microsoft/sp-dialog": "~1.4.0"
   },
   "devDependencies": {
-    "@microsoft/sp-build-web": "~1.3.0",
-    "@microsoft/sp-module-interfaces": "~1.3.0",
-    "@microsoft/sp-webpart-workbench": "~1.3.0",
+    "@microsoft/sp-build-web": "~1.4.0",
+    "@microsoft/sp-module-interfaces": "~1.4.0",
+    "@microsoft/sp-webpart-workbench": "~1.4.0",
     "@types/chai": ">=3.4.34 <3.6.0",
     "@types/mocha": ">=2.2.33 <2.6.0",
+    "ajv": "~5.2.2",
     "gulp": "~3.9.1",
-    "sp-pnp-js": "^3.0.1"
+    "sp-pnp-js": "^3.0.4"
   }
 }
diff --git a/samples/js-command-clone/src/extensions/spfxClone/SpfxCloneCommandSet.manifest.json b/samples/js-command-clone/src/extensions/spfxClone/SpfxCloneCommandSet.manifest.json
@@ -18,7 +18,7 @@
   "items": {
     "spfxClone": {
       "title": { "default": "Clone" },
-      "iconImageUrl": "icons/cancel.png",
+      "iconImageUrl": "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAAAAXNSR0IArs4c6QAAAARnQU1BAACxjwv8YQUAAAAJcEhZcwAADsMAAA7DAcdvqGQAAAFbSURBVDhPtZOtTgNBEIBnb/cA0WS3FwiGhD4AAolE8AAIBALLGyARJBUIFApTX4HkARDICiQCUVHRkOve8dOkQEuXmWOOHHcLreFLNjc7/3s7Cz6SwBwkSvcSZRwtq0xslT5i82wwqJ+GepO3MIBoDXWjB1ipseqbgL8lxPnUiU4q9Xa6qBuBmvaEc61ViIfsMBuseJ0nwCN0WV3hlw7m538SdGF9yQE0JsIN398WXlFlnqG2/GX9iTeBlk9NgQkkBJ1Qjfsom4lSF2z+m4GKtugaixXp+hJp7gZS77HKD7atrDS3uWMxiS9xBSv1CTpdkozfNq4RJjzNjAh2cZbbK9Dk5RWyTnB8KYA6Ypfs53qPUm6dsEF9H+f/CnU7tI+l3qXB8h6l2LoPG9Y3KAgf2EsK2vBR2mxGBxzV4uMpw0H3WOgm32PMmGS8YlRI3XRCHJM8Nw5a0cfj4ScBDIzf6gQVQAAAAABJRU5ErkJggg==",
       "type": "command"
     }
   }

diff --git a/samples/js-command-clone/tsconfig.json b/samples/js-command-clone/tsconfig.json
@@ -7,10 +7,19 @@
     "declaration": true,
     "sourceMap": true,
     "experimentalDecorators": true,
+    "skipLibCheck": true,
+    "typeRoots": [
+      "./node_modules/@types",
+      "./node_modules/@microsoft"
+    ],
     "types": [
       "es6-promise",
-      "es6-collections",
       "webpack-env"
+    ],
+    "lib": [
+      "es5",
+      "dom",
+      "es2015.collection"
     ]
   }
 }