Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PropertyFieldListPicker add optional property for target site #21

Closed
joelfmrodrigues opened this issue Jan 5, 2018 · 3 comments

Comments

@joelfmrodrigues
Copy link
Contributor

commented Jan 5, 2018

Category

[ X] Enhancement

[ ] Bug

[ ] Question

Expected / Desired Behavior / Question

Add an optional property to allow the target site url to be configured so that the component can load lists from a different site (it is a common development scenario to have components that read data from the root site for example)

Observed Behavior

Control default to loading lists from the current site.

Happy to help if the suggestion gets approved.
Thanks,
Joel

@estruyf estruyf added the enhancement label Jan 5, 2018
@estruyf estruyf added the help wanted label Mar 2, 2018
@joelfmrodrigues

This comment has been minimized.

Copy link
Contributor Author

commented Jun 15, 2018

Started working on this

@joelfmrodrigues

This comment has been minimized.

Copy link
Contributor Author

commented Jul 5, 2018

Finally managed to complete this, sorry I was too busy and it took a long time

@estruyf estruyf added this to the v1.8.0 milestone Jul 13, 2018
@estruyf

This comment has been minimized.

Copy link
Collaborator

commented Jul 13, 2018

Thanks @joelfmrodrigues, this got merged and released in v1.8.0 today.

@estruyf estruyf closed this Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.