Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PropertyFieldListPicker add optional property for target site #21

Closed
joelfmrodrigues opened this issue Jan 5, 2018 · 3 comments
Closed

PropertyFieldListPicker add optional property for target site #21

joelfmrodrigues opened this issue Jan 5, 2018 · 3 comments
Labels
help wanted
Milestone
v1.8.0

Comments

@joelfmrodrigues
Copy link
Collaborator

Category

[ X] Enhancement

[ ] Bug

[ ] Question

Expected / Desired Behavior / Question

Add an optional property to allow the target site url to be configured so that the component can load lists from a different site (it is a common development scenario to have components that read data from the root site for example)

Observed Behavior

Control default to loading lists from the current site.

Happy to help if the suggestion gets approved.
Thanks,
Joel
@joelfmrodrigues
Copy link
Collaborator Author

Started working on this

@joelfmrodrigues joelfmrodrigues mentioned this issue Jul 5, 2018
Merged
@joelfmrodrigues
Copy link
Collaborator Author

Finally managed to complete this, sorry I was too busy and it took a long time

@estruyf estruyf added this to the v1.8.0 milestone Jul 13, 2018
@estruyf estruyf mentioned this issue Jul 13, 2018
Merged
@estruyf
Copy link
Member

estruyf commented Jul 13, 2018

Thanks @joelfmrodrigues, this got merged and released in v1.8.0 today.

@estruyf estruyf closed this as completed Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
v1.8.0
Development

No branches or pull requests
2 participants
@estruyf @joelfmrodrigues