Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PropertyFieldPeoplePicker Validation does not work as expected. #33

Closed
SamipPatel opened this issue Feb 26, 2018 · 1 comment
Closed

Comments

@SamipPatel
Copy link

Category

[ ] Enhancement

[X] Bug

[ ] Question

Expected / Desired Behavior / Question

Added validation function to onGetErrorMessage property of a PropertyFieldPeoplePicker field. Wrote the validation function to fail on purpose and expected to see error message in property pane under the people picker field.

Observed Behavior

No error message was displayed.

Notes:

  1. Specifically, it looks like there is an issue on line 162 of PropertyFieldPeoplePickerHost.tsx where the error message logic is only run if the result is 'undefined'.
  2. I updated that line locally to see what the error message would look like and observed that the css was not rendering as expected. The people picker did not have a red outline and the error message was not displayed in red text.
@estruyf estruyf added the bug label Mar 2, 2018
estruyf added a commit that referenced this issue Mar 2, 2018
@estruyf
Copy link
Member

estruyf commented Mar 2, 2018

Thanks for reporting this, I have done the changes to the property control. It is planned to be released in the next version v1.4.1. Feel free to already test it out by using the beta version. Instructions for installing the beta version can be found here: https://sharepoint.github.io/sp-dev-fx-property-controls/beta/

@estruyf estruyf closed this as completed Mar 2, 2018
@estruyf estruyf mentioned this issue Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants