New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PropertyFieldPeoplePicker - No suggestions returned when using Security Groups, Multi-select and NO duplicates. #90

Closed
petecuttriss opened this Issue Aug 15, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@petecuttriss

petecuttriss commented Aug 15, 2018

Category

  • Enhancement
  • Bug
  • Question

Version 1.9.0

Expected / Desired Behavior / Question

Using the PropertyFieldPeoplePicker, I have set it so that allowDuplicates is false, multiSelect is true and the principalType is PrincipalType.Security. I would expect to be able to select multiple security groups. After making a single initial selection, and then when I begin typing for a second selection, I would expect to see suggested groups.

Observed Behavior

When no groups are selected, I can being typing and get suggested security groups as expected. Once I make a selection and begin to look for a second security group I get 'No results found'. If I change the PropertyFieldPeoplePicker so that allowDuplicates is set to true (or add further PrincipalTypes), I can enter and receive suggestions for more than one security group.

Steps to Reproduce

Add a PropertyFieldPeoplePicker control to a web part project and configure it so that:

  • allowDuplicate: false,
  • multiSelect: true,
  • principalType: [PrincipalType.Security]

e.g.
PropertyFieldPeoplePicker('securityGroups', { label: 'NO Duplicates, Multi-select, PrincipalType.Security', initialData: this.properties.securityGroups, allowDuplicate: false, multiSelect: true, principalType: [PrincipalType.Security], onPropertyChange: this.onPropertyPaneFieldChanged, context: this.context, properties: this.properties, onGetErrorMessage: null, deferredValidationTime: 0, key: 'securityGroupsFieldId' })

Run the project using gulp serve and then browse to the SharePoint Online Workbench _layouts/15/workbench.aspx.

Edit the web part and select a security group from the PropertyFieldPeoplePicker. Then attempt to select a second security group which you know exists.

issue_example

Thanks for these controls and all your efforts, they're great.

@estruyf estruyf added this to the 1.10.0 milestone Sep 6, 2018

estruyf added a commit that referenced this issue Sep 6, 2018

@estruyf estruyf added the bug label Sep 6, 2018

@estruyf

This comment has been minimized.

Collaborator

estruyf commented Sep 6, 2018

Thanks @petecuttriss for reporting this. I have fixed this bug and will be available in version 1.10.0. You can already test out the beta via: https://sharepoint.github.io/sp-dev-fx-property-controls/beta/

security-group

@petecuttriss

This comment has been minimized.

petecuttriss commented Sep 11, 2018

Hi Elio,

I've tested out this fix in the beta and it's working great.

Thanks
Pete

@estruyf

This comment has been minimized.

Collaborator

estruyf commented Sep 12, 2018

Thanks for testing it!

Will close this issue. The release of the new version is planned later this week.

@estruyf estruyf closed this Sep 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment