Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
PropertyFieldCollectionData crashes browser while editing URL #99
Please specify what version of the library you are using: [1.11.0]
I haven't been able to narrow down what triggers this bug exactly, but when trying to copy in a SharePoint link with encoding (e.g. %20), the browser will lock up and throw an alert about a slow running script. I have replicated this in both Firefox and Chrome, however I can put special characters in most URLs, but SharePoint ones seem to be causing it problems.
Steps to Reproduce
Create a new application with a PropertyFieldCollectionData property, set one of the fields to
The tab then locks up and throws a 'page unresponsive error'.
Interestingly, if I put a smaller URL like the following:
Then the browser freezes momentarily for a couple of seconds, but then resumes - while the first link will freeze it completely. Replacing the %20 with spaces fixes the problem altogether.
That said, I have been able to paste in URLs containing %20 without any problem, the following will work fine for example:
I've also noticed that any URL containing %20 also fails validation, which is incorrect.
added a commit
Oct 26, 2018
Solved the bug by implementing a new RegEx statement. Would you be able to test it out in the latest beta? You find more information about installing a beta version here: https://sharepoint.github.io/sp-dev-fx-property-controls/beta/