Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add drag drop support for notifications with file name #5540

Merged
merged 2 commits into from Apr 28, 2021

Conversation

Craftplacer
Copy link
Contributor

Title says all, here's a quick demonstration:

rPm3VcXSSh.mp4

@Jaex
Copy link
Member

Jaex commented Apr 28, 2021

Thanks 👍

@Jaex Jaex merged commit e607cc4 into ShareX:master Apr 28, 2021
@Jaex
Copy link
Member

Jaex commented Apr 30, 2021

Clicking on thumbnail not running any click action anymore. That's probably why I did not add drag n drop support before.

Jaex added a commit that referenced this pull request Apr 30, 2021
This reverts commit e607cc4, reversing
changes made to 7f88c8c.
@Craftplacer
Copy link
Contributor Author

Craftplacer commented Apr 30, 2021

Thanks for telling me, I have attempted to implement a fix under another branch drag-drop-notifications.

It now uses a threshold area that the user has to drag along until a drag and drop gets issued. That should fix other mouse events like clicking. I tested myself and it seems like the issue has been resolved.

Please check it out and let me know whether it fixed that issue.

@Jaex
Copy link
Member

Jaex commented May 3, 2021

Can you open PR for it? Will be easier for me to test it.

@thewaliii
Copy link

thewaliii commented May 25, 2021

Man thaaaaaaaank you so much.... best feature ever, I asked for something similar 2 years ago! 🤩🤗 #4348

@chocolateimage
Copy link

This is such a good feature!
I wanted this feature for soooo long.

Mattes0h pushed a commit to Mattes0h/ShareX that referenced this pull request Jul 5, 2021
This reverts commit e607cc4, reversing
changes made to 7f88c8c.
@goyalyashpal
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants