Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constraints should be checked in parallel. #2

Open
Jonas-Sander opened this issue Nov 2, 2020 · 0 comments
Open

Constraints should be checked in parallel. #2

Jonas-Sander opened this issue Nov 2, 2020 · 0 comments

Comments

@Jonas-Sander
Copy link
Collaborator

Instead of iterating through the constraints we should execute them in parallel via .map as await blocks the loop until resolved.

    for (final constraint in jwtConstraints) {
      final satisfied = await constraint.isSatisfiedBy(jwt);
      _logger.finer(
          'JWT-Token constraint ${constraint.description} satisfied: $satisfied');
      if (!satisfied) {
        throw ArgumentError(
            'JWT does not satisfy constraint: ${constraint.description}');
      }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant