Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coverage folder to .gitignore #170

Merged
merged 4 commits into from May 12, 2022
Merged

Conversation

nilsreichardt
Copy link
Member

I just saw that we had a app/coverage folder. I think this was a mistake to commit this folder. So I added coverage/ to the top level .gitignore. Maybe Flutter also adds the coverage as default to the .gitignore file: flutter/flutter#101349.

@github-actions
Copy link

github-actions bot commented May 7, 2022

Visit the preview URL for this PR (updated for commit 34448c3):

https://sharezone-test--pr170-add-coverage-to-giti-f3i8b1zm.web.app

(expires Thu, 19 May 2022 19:13:22 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@Jonas-Sander
Copy link
Collaborator

Just for my understanding: Since it's top-level it will also apply for e.g. packages inside /lib, correct?

@nilsreichardt
Copy link
Member Author

Just for my understanding: Since it's top-level it will also apply for e.g. packages inside /lib, correct?

Correct

@nilsreichardt nilsreichardt enabled auto-merge (squash) May 12, 2022 19:06
@nilsreichardt nilsreichardt merged commit 785339e into main May 12, 2022
@nilsreichardt nilsreichardt deleted the add-coverage-to-gitignore branch May 12, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants