Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add licence header commands to Sharezone CLI. #326

Closed
Jonas-Sander opened this issue Jan 1, 2023 · 1 comment · Fixed by #339
Closed

Add licence header commands to Sharezone CLI. #326

Jonas-Sander opened this issue Jan 1, 2023 · 1 comment · Fixed by #339
Labels
sharezone cli

Comments

@Jonas-Sander
Copy link
Collaborator

Create sz cli commands that:

  • Check that all files have the correct licence headers
  • Add licence header to all files that do not yet have to correct header
@Jonas-Sander
Copy link
Collaborator Author

#325 (review)

@Jonas-Sander Jonas-Sander mentioned this issue Jan 1, 2023
Merged
@Jonas-Sander Jonas-Sander mentioned this issue Jan 23, 2023
Merged
Jonas-Sander added a commit that referenced this issue Jan 24, 2023
@Jonas-Sander
Add license check commands to Sharezone CLI (#339)
5fb83b5 
Added the following commands:
* `sz license-headers check` - Check that all files have the necessary
license headers.
* `sz license-headers add` - Add the necessary license headers to all
files that do not have them yet.

Caveat: `addlicense` ignores the `-ignore
"**/GeneratedPluginRegistrant.swift"` when trying to add license
headers.
This means that it will always add the header to the
GeneratedPluginRegistrant.swift.
This happens even if I run the `addlicense` command locally directly in
the command line.

**Command SOT**
I added the file `bin\source_of_truth\commands_source_of_truth.yaml` so
that there is only one correct version of the addlicense commands. More
explanation is embedded in the file.

Closes #326
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
sharezone cli
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add license check commands to Sharezone CLI SharezoneApp/sharezone-app
1 participant
@Jonas-Sander