Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #6

Merged
merged 55 commits into from Jun 12, 2019
Merged

Develop #6

merged 55 commits into from Jun 12, 2019

Conversation

Sharparam
Copy link
Owner

@Sharparam Sharparam commented Jun 11, 2019

Description

Mostly documentation updates, with some restructuring to code and added tests.

Motivation and Context

N/A

How Has This Been Tested?

Unit testing on for example the new Base64 helper.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing
    functionality and/or APIs to change)
  • Documentation

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes where applicable.
  • All new and existing tests passed.

@Sharparam Sharparam self-assigned this Jun 11, 2019
@AppVeyorBot
Copy link

@codecov
Copy link

codecov bot commented Jun 11, 2019

Codecov Report

Merging #6 into master will decrease coverage by 0.6%.
The diff coverage is 17.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
- Coverage   17.62%   17.01%   -0.61%     
==========================================
  Files         239      240       +1     
  Lines        2400     2509     +109     
  Branches      321      346      +25     
==========================================
+ Hits          423      427       +4     
- Misses       1899     2014     +115     
+ Partials       78       68      -10
Impacted Files Coverage Δ
src/Cshrix/Data/Events/Content/ReceiptData.cs 100% <ø> (ø) ⬆️
.../Cshrix/Data/Containers/RoomVisibilityContainer.cs 0% <ø> (ø)
...rix/Data/Events/Content/FormattedMessageContent.cs 0% <ø> (ø) ⬆️
src/Cshrix/Data/Containers/UserIdContainer.cs 0% <ø> (ø)
src/Cshrix/Data/Chunk.cs 0% <ø> (ø) ⬆️
src/Cshrix/Data/Search/SearchCategories.cs 0% <ø> (ø) ⬆️
...rix/Data/Events/Content/ThirdPartyInviteContent.cs 0% <ø> (ø) ⬆️
...Cshrix/Data/Identifiers/LocalpartUserIdentifier.cs 0% <ø> (ø)
src/Cshrix/Data/VersionsResponse.cs 0% <ø> (ø) ⬆️
src/Cshrix/Data/Devices/Device.cs 0% <ø> (ø)
... and 234 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62ac1b4...df46d19. Read the comment docs.

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@Sharparam Sharparam merged commit 4b300ee into master Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants