Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TTS for greeting. #121

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Add TTS for greeting. #121

merged 2 commits into from
Jul 20, 2023

Conversation

hksfang
Copy link
Collaborator

@hksfang hksfang commented Jul 19, 2023

Test result video on a local test server for both audio and text:
https://drive.google.com/file/d/1Z_-OlBZq4lpjzHNKj9QjnWTspKaf_izW/view?usp=sharing

Copy link
Collaborator

@pycui pycui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Can you add testing results to your PR description? (for both audio and text)

@@ -359,7 +359,6 @@ talkButton.addEventListener("click", function() {
messageButton.style.display = "flex";
stopCallButton.style.display = "flex";
soundWave.style.display = "flex";
textContainer.textContent = "Hi, my friend, what brings you here today?";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can still be kept for visual prompt

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@@ -109,6 +111,16 @@ async def handle_receive(
previous_transcript = None
token_buffer = []

# greet the user
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capitalize

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@hksfang
Copy link
Collaborator Author

hksfang commented Jul 20, 2023

Thanks a lot! Can you add testing results to your PR description? (for both audio and text)

Sure, added a video link for the testing result in the description

@hksfang hksfang requested a review from pycui July 20, 2023 03:11
@hksfang hksfang requested a review from pycui July 20, 2023 05:40
Copy link
Collaborator

@pycui pycui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pycui pycui merged commit 6280b6d into Shaunwei:main Jul 20, 2023
yaohaizhou pushed a commit to yaohaizhou/RealChar that referenced this pull request Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants