Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heatmap plotting fails when attribute has blanks and a single unique value #22

Closed
ressy opened this issue Dec 10, 2018 · 1 comment
Closed

Heatmap plotting fails when attribute has blanks and a single unique value #22

ressy opened this issue Dec 10, 2018 · 1 comment
Labels
bug
Milestone
Version 0.2.2

Comments

@ressy
Copy link
Member

ressy commented Dec 10, 2018

plot_heatmap fails if the given attribute has only a single unique value and NA entries present:

Error in grid.pretty(range(as.vector(breaks))) :
  infinite axis extents [GEPretty(nan,nan,5)]

We can fix this by updating the breaks calculation to exclude NA when finding the max attribute value.
@ressy ressy added the bug label Dec 10, 2018
@ressy ressy added this to the Version 0.2.2 milestone Dec 10, 2018
ressy added a commit that referenced this issue Dec 10, 2018
@ressy
Add failing test set for plot_heatmap (For #22)
c7cf032
ressy added a commit that referenced this issue Dec 10, 2018
@ressy
For #22: fix NA edge case in plot_heatmap
934c931
ressy added a commit that referenced this issue Dec 10, 2018
@ressy
Merge branch 'test-plot-heatmap' into dev
a01deb8 
Relates to #22
@ressy ressy mentioned this issue Dec 11, 2018
Closed
@ressy
Copy link
Member Author

ressy commented Dec 14, 2018

Fixed in 0.2.2.

@ressy ressy closed this as completed Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Version 0.2.2
Development

No branches or pull requests
1 participant
@ressy