1.9 Beta2 has broken Umbraco 6.2.5 backend

[xumix]

I don't understand why, but it simply skips some of the js files in debug=false mode
For example umbracolink plugin has stopped working: if you click a node in the popup window it says setFromValue is undefined

[Shazwazza]

anything in your umbraco logs?

[xumix]

ooops, really:

2016-05-18 16:52:01,996 [192] ERROR Umbraco.Web.UI.CdfLogger - [Thread 186] Could not write file C:\Projects\Portal\External Portal\EIIP\EIIP\umbraco_client\tinymce3\plugins\umbracolink\js\umbracolink.js contents to stream. EXCEPTION: Error: JSMIN unterminated string literal: 10

System.Exception: Error: JSMIN unterminated string literal: 10

   at ClientDependency.Core.CompositeFiles.JSMin.HandleStringLiteral() in X:\Projects\ClientDependency\ClientDependency\ClientDependency.Core\CompositeFiles\JSMin.cs:line 341
   at ClientDependency.Core.CompositeFiles.JSMin.Action(Int32 d) in X:\Projects\ClientDependency\ClientDependency\ClientDependency.Core\CompositeFiles\JSMin.cs:line 223
   at ClientDependency.Core.CompositeFiles.JSMin.ExecuteJsMin() in X:\Projects\ClientDependency\ClientDependency\ClientDependency.Core\CompositeFiles\JSMin.cs:line 192
   at ClientDependency.Core.CompositeFiles.JSMin.Minify(TextReader reader) in X:\Projects\ClientDependency\ClientDependency\ClientDependency.Core\CompositeFiles\JSMin.cs:line 97
   at ClientDependency.Core.CompositeFiles.JSMin.CompressJS(Stream stream) in X:\Projects\ClientDependency\ClientDependency\ClientDependency.Core\CompositeFiles\JSMin.cs:line 74
   at ClientDependency.Core.CompositeFiles.Providers.BaseCompositeFileProcessingProvider.MinifyFile(Stream fileStream, ClientDependencyType type) in X:\Projects\ClientDependency\ClientDependency\ClientDependency.Core\CompositeFiles\Providers\BaseCompositeFileProcessingProvider.cs:line 613
   at ClientDependency.Core.CompositeFiles.DefaultFileWriter.WriteContentToStream(BaseCompositeFileProcessingProvider provider, StreamWriter sw, Stream stream, ClientDependencyType type, HttpContextBase context, String originalUrl) in X:\Projects\ClientDependency\ClientDependency\ClientDependency.Core\CompositeFiles\DefaultFileWriter.cs:line 110
   at ClientDependency.Core.CompositeFiles.DefaultFileWriter.WriteToStream(BaseCompositeFileProcessingProvider provider, StreamWriter sw, FileInfo fi, ClientDependencyType type, String origUrl, HttpContextBase http) in X:\Projects\ClientDependency\ClientDependency\ClientDependency.Core\CompositeFiles\DefaultFileWriter.cs:line 23

[Shazwazza]

Thanks, i'll test that file and see why it's failing

[Shazwazza]

I've uploaded a new version to nuget: https://www.nuget.org/packages/ClientDependency/1.9.0-beta4

Problem was something stupid on my part when parsing JS string templates. The reason this has been in beta for a while is because I was fixing up a bunch of issues with the original JsMin. I've created a diff project to track those here: github.com/shazwazza/jsminsharp . JsMin has been great but had a few issues so I've fix a lot of it up but in the process have made a few mistakes. Should all be good now I hope! There's lots of tests created there and have tested several projects with this including the latest Umbraco.

[xumix]

So good! Thanks a lot!

[xumix]

Unfortunately, this is not the end...

The error disappears if debug=false

[xumix]

the errors:

2016-05-19 11:57:30,106 [129] ERROR Umbraco.Web.UI.CdfLogger - [Thread 109] Could not load file contents from /umbraco/webservices/legacyAjaxCalls.asmx/js. Domain is not white-listed.
2016-05-19 11:57:30,117 [129] ERROR Umbraco.Web.UI.CdfLogger - [Thread 93] Could not load file contents from /umbraco/webservices/nodeSorter.asmx/js. Domain is not white-listed.

[xumix]

I've disabled rogue compression, and it is ok now, thanks!

[Shazwazza]

Interesting, can you send me your cdf config when you got this issue, i'm just curious to see what is in there as I wouldn't suspect the rogue compression stuff to include these requests.

[xumix]

<add name="CompositeFileProcessor" type="ClientDependency.Core.CompositeFiles.Providers.CompositeFileProcessingProvider, ClientDependency.Core" enableCssMinify="true" enableJsMinify="true" persistFiles="true" compositeFilePath="~/App_Data/TEMP/ClientDependency" urlType="MappedId" pathUrlFormat="{dependencyId}/{version}/{type}" />

<rogueFileCompression>
      <add path="*" compressJs="true" compressCss="true" jsExt=".js,asmx/js" cssExt=".css">
      </add>
    </rogueFileCompression>

[xumix]

bundleDomains attribute has been removed, after i've added bundleDomains="localhost" it fixed the errors

[Shazwazza]

Ah so rogue file compression by default tries to include asmx/js calls which are excluded from being detected as local static files which is why it is requiring you to white list them. Otherwise, you could remove that from the 'jsExt' attribute if you wanted to exclude those from being compressed.

[Shazwazza]

I'll remove the asmx/js from default config that we ship with

[xumix]

great! thanks