Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add Options to Control Etag and Cache-Control headers. #48

Closed
josh-sachs opened this Issue Sep 17, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@josh-sachs
Copy link

josh-sachs commented Sep 17, 2016

The following options would be beneficial to those of us more concerned with the "Bundling Workflow" vs all the optimizations. I imagine it would be trivial to add to the SmidgeOptions...

EnableEtag = false
CacheControlMaxAge = integer (0 == disabled).

The idea is I can work on all my build processes to auto-version and whatnot once I've got an MVP, instead of needing to solve for cache-busting/versioning while my app is still being developed. I know "debug==true" is an option, but we currently stage against the bundled/minified resources and having to worry about forgetting to increment versions / clear cache and all of that during this process is overhead I'd like to push off post MVP.

@Shazwazza

This comment has been minimized.

Copy link
Owner

Shazwazza commented Sep 19, 2016

Yup can look into this, I'm in the middle of working on a v2 which will also help solve the debug==true stuff. In v2 you can have the pipelines all execute for any files types/bundles and have different options for different environments (i.e. debug, production). This way you can have all the minification still being performed in debug but not bundled (for example). I can add more options like this too.

Shazwazza added a commit that referenced this issue Sep 27, 2016

File watcher! #42
Feature Request: Add Options to Control Etag and Cache-Control headers. #48
This is a huge update, this adds fluent builders for defining debug vs production options, adds lots of new options for file watching and caching, gets file watching working including refreshing of persistent files.
@Shazwazza

This comment has been minimized.

Copy link
Owner

Shazwazza commented Sep 27, 2016

This is implemented now, for example this is how you would do it: c89986f#diff-30fbbf9f392f23bc5a5b6d71102e6bd4R99

This will be part of Smidge 2.0 (just need to find time to finish it now)

@Shazwazza Shazwazza closed this Sep 27, 2016

@Shazwazza Shazwazza added this to the 2.0 milestone Sep 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.