Check if request headers exist #128
Conversation
These headers are not guaranteed.
|
As a side note, @Shazwazza, how useful is the IE6 check still? Maybe remove it? I doubt anyone uses that ancient browser anymore. |
|
Yep we can remove that check :) can you update the PR with the change? |
Done :) |
src/Smidge/RequestHelper.cs
Outdated
|
|
||
| CompressionType parsed = CompressionType.Parse(encoding); | ||
|
|
||
| // Brotli is typically last in the accept encoding header. | ||
| if (parsed == CompressionType.Brotli) | ||
| if (parsed.Equals(CompressionType.Brotli)) |
There was a problem hiding this comment.
Do we want to do any invariant checking for Equals here or no?
There was a problem hiding this comment.
No, this is a struct. I changed it to Equals instead of == because VS was warning about a not implemented == operator (seems like a VS bug as CompressionType implements the == operator as well).
There was a problem hiding this comment.
@Shazwazza Reverted these changes, if you could merge and release a new version on NuGet that'd be great 👍
|
Ahh, you already said that. I think it will since it's trying to read from the dictionary correctly. |
|
Yes, this fixes that problem, it's the same issue I had. The User-Agent header I can understand missing but I also had some Chrome browsers not sending Accept-Encoding for whatever reason. |
|
Cool, i've just published the release 👍 |
These headers are not guaranteed.