Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to IHeaderDictionary #134

Merged
merged 1 commit into from
Nov 30, 2021
Merged

Switch to IHeaderDictionary #134

merged 1 commit into from
Nov 30, 2021

Conversation

PhyxionNL
Copy link
Contributor

StringValues isn't always split (sometimes it contains one item such as "gzip, deflate"), so use IHeaderDictionary and call GetCommaSeparatedValues. This way the result is guaranteed.

@Shazwazza A quick review / update to NuGet would be appreciated, this affects some users.

@Shazwazza Shazwazza added the bug label Nov 25, 2021
@Shazwazza Shazwazza added this to the 4.0.3 milestone Nov 25, 2021
Copy link
Owner

@Shazwazza Shazwazza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do this without breaking changes?

src/Smidge.Core/IRequestHelper.cs Outdated Show resolved Hide resolved
@Shazwazza Shazwazza merged commit 391ed15 into Shazwazza:master Nov 30, 2021
@PhyxionNL PhyxionNL deleted the header-dictionary branch November 30, 2021 13:06
@PhyxionNL
Copy link
Contributor Author

Would it be possible to push version 4.0.3 to NuGet now @Shazwazza? 🎉

@Shazwazza
Copy link
Owner

Yep, will push shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants