Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #151 #152

Merged
merged 5 commits into from
May 4, 2022
Merged

Fixes #151 #152

merged 5 commits into from
May 4, 2022

Conversation

PhyxionNL
Copy link
Contributor

@PhyxionNL
Copy link
Contributor Author

@Shazwazza If you could merge and release 4.0.5 that'd be great 👀

@Shazwazza
Copy link
Owner

My concern is that now this will not match # at all? Also is there unit tests for this? Else can some be made?

@PhyxionNL
Copy link
Contributor Author

My concern is that now this will not match # at all?

It will match, that was already present.

Also is there unit tests for this? Else can some be made?

There's this one, https://github.com/Shazwazza/Smidge/blob/master/test/Smidge.Tests/CssUrlProcessorTests.cs#L40, but that doesn't cover encoded URLs, I'll add one.

@PhyxionNL
Copy link
Contributor Author

Failure is unrelated, + squash & merge :)

@Shazwazza Shazwazza merged commit a962307 into Shazwazza:master May 4, 2022
@PhyxionNL PhyxionNL deleted the patch-1 branch May 24, 2022 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PhyxionNL @Shazwazza