Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not found page #190

Merged
merged 4 commits into from
Apr 2, 2024
Merged

Not found page #190

merged 4 commits into from
Apr 2, 2024

Conversation

jet1992
Copy link

@jet1992 jet1992 commented May 14, 2023

Hello, here was problem using smidge when map(//# sourceMappingURL=url) is in js/css file and we want to have that line because if version changed etc it has by default, but we don't using map files.
Smidge throws error: Could not parse {bundleId} as a valid smidge path and in site dev tools shows:
image
And it floods log files with errors, but this is just not found so better solution is warning and not error.
Now I fixed if bundle not found when 404 code returned from controller, it's better solution with this problem:
image

@Shazwazza
Copy link
Owner

Hi! sorry for the delay.

Changes look good I think but just curious about all the bootstrap stuff added. I haven't merged/tested this out yet but is this just making the test webapp nice?

@jet1992
Copy link
Author

jet1992 commented Jun 18, 2023

Hi, I added bootstrap only for test. I removed bootstrap lib and added only one css for test.

@Shazwazza Shazwazza merged commit d19268a into Shazwazza:master Apr 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants