Fix bad comparison against None using ==

[mdlavin]

While running GPyOpt on python3 I started to see the following failure:

Traceback (most recent call last):
  File "/Users/mattlavin/Projects/GPyOpt/GPyOpt/testing/test_parallelization.py", line 102, in test_run
    unittest_result = run_eval(problem_config= self.problem_config, f_inits= self.f_inits, method_config=m_c, name=name, outpath=self.outpath, time_limit=None, unittest = self.is_unittest)
  File "/Users/mattlavin/Projects/GPyOpt/GPyOpt/testing/driver.py", line 47, in run_eval
    verbosity       = m_c['verbosity'])
  File "/Users/mattlavin/Projects/GPyOpt/GPyOpt/methods/bayesian_optimization.py", line 458, in run_optimization
    super(BayesianOptimization, self).run_optimization(max_iter = max_iter, max_time = max_time,  eps = eps, verbosity=verbosity, save_models_parameters = save_models_parameters, report_file = report_file, evaluations_file= evaluations_file, models_file=models_file)
  File "/Users/mattlavin/Projects/GPyOpt/GPyOpt/core/bo.py", line 103, in run_optimization
    self._update_model()
  File "/Users/mattlavin/Projects/GPyOpt/GPyOpt/core/bo.py", line 198, in _update_model
    self._save_model_parameter_values()
  File "/Users/mattlavin/Projects/GPyOpt/GPyOpt/core/bo.py", line 209, in _save_model_parameter_values
    if self.model_parameters_iterations == None:
ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()

It turns out that an array was being compared against None with == instead of is switching to is avoided the ambiguous type coercion.

[mdlavin]

This would fix #96 and #98

[gioelelm]

It would be useful to have this merged!

[lawrennd]

Hi Giole, A few of the team are away at the moment, when they're back we'll get it reviewed

…

On Thu, 3 Aug 2017, 19:35 Gioele La Manno, ***@***.***> wrote: It would be useful to have this merged! — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#104 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAIKWt-rR15j8ejMEHZUKkusNCZ_nZzAks5sUgTjgaJpZM4OgLpT> .

[MarkusPrim]

Any update on this? It is easy to fix locally but still annoying.

[sverzijl]

This actually occurs elsewhere in the code. The scary thing is that it is a silent error in the cases of 'initial_design_numdata==None' in bayesian_optimizer.py

I only noticed it because setting this value seemed to do nothing.

[javiergonzalezh]

We have done the merge of the PR on this already so it should work now.

…

On 28 August 2017 at 11:55, sverzijl ***@***.***> wrote: This actually occurs elsewhere in the code. The scary thing is that it is a silent error in the cases of 'initial_design_numdata==None' in bayesian_optimizer.py I only noticed it because setting this value seemed to do nothing. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#104 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGiS89Q958nbTjHr9d3E55f6YlMmPxKaks5scpyjgaJpZM4OgLpT> .

[DaniloRezende]

Hi. It looks like the pip version still has this bug.

[javiergonzalezh]

Thanks for pointing that out. That's because we haven't updated the pip version yet. The code for the new release is in the devel brach, in which that issue has been corrected. 2017-10-07 11:22 GMT+01:00 Danilo J. Rezende <notifications@github.com>:

…

Hi. It looks like the pip version still has this bug. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#104 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGiS8xxZqLJ6nAF2KnQ_kNVeeqVOeYaTks5sp1EBgaJpZM4OgLpT> .