Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request]: Administrator requires a custodian to read and sign a document when assigning long term custody #461

Open
jurrejansen opened this issue Oct 17, 2023 · 25 comments

Comments

@jurrejansen
Copy link

jurrejansen commented Oct 17, 2023

Contact Details

jurre@shelf.nu

Is your feature request related to a problem? Please describe?

As an IT manager, whenever I check out an asset to an employee. I want to have the option to enhance the 'formality' of the checkout. Recording the date/time/IP address and signature of an employee that received an asset from me would do this. In case this employee leaves the company. We can then rightfully request the return of all the assets that he / she got access and signed off for.

Describe the solution you'd like

Administrator can attach a pre-configured PDF template document when assigning custody. Optionally the administrator can decide if the custodian needs to leave a signature electronically before custody of the asset is officially assigned. We are going to have both non-registered team members andregistered team members (users) that actually have an account / email. Both can be custodians.

[WIP] NON-REGISTERED TEAM MEMBERS
https://www.figma.com/file/ykvc0MhPeNLsrJ4tJsKosQ/Shelf-%7C-UX-Scenarios?type=design&node-id=534-92886&mode=design

REGISTERED TEAM MEMBERS (USERS)
https://www.figma.com/file/ykvc0MhPeNLsrJ4tJsKosQ/Shelf-%7C-UX-Scenarios?type=design&node-id=626-29627&mode=design

Describe alternatives you've considered

No response

Additional context

No response

@jurrejansen
Copy link
Author

@carlosvirreira @DonKoko Any comments here? Ignore the non-registered team members designs as we discussed to not implement this option when assigning custody to non-registered team members.

@carlosvirreira
Copy link
Contributor

If we have to ignore 1 flow then strikethrough it.

before the text

@carlosvirreira
Copy link
Contributor

carlosvirreira commented Nov 21, 2023

/bounty 40

Copy link

algora-pbc bot commented Nov 21, 2023

💎 $40 bounty • Shelf

Steps to solve:

  1. Start working: Comment /attempt #461 with your implementation plan
  2. Submit work: Create a pull request including /claim #461 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to Shelf-nu/shelf.nu!

Add a bountyShare on socials

Attempt Started (GMT+0) Solution
🔴 @feliciien Nov 22, 2023, 7:45:26 PM WIP
🟢 @rajdip-b Dec 19, 2023, 4:41:49 PM #629

@carlosvirreira
Copy link
Contributor

carlosvirreira commented Nov 21, 2023

Note for the future bounty attempter. You might see there some styles that are new layout wise. I want to ask you to please ignore them and focus on the new dashboard setting tab and the fields inside of it only.

This bounty is part of a bigger epic (collect signatures for custody assignments).

Any questions about this bounty can be discussed on our Discord: https://discord.gg/nGdu8zHG

@feliciien
Copy link

feliciien commented Nov 22, 2023

/attempt #461

Options

@feliciien
Copy link

feliciien commented Nov 22, 2023

Hello when i run npm run setup i have this error message : "Error: P1001: Can't reach database server at db.nxphroyicgnenkxwolrg.supabase.co:5432

Please make sure your database server is running at db.nxphroyicgnenkxwolrg.supabase.co:5432.
ERROR: "setup:db" exited with 1."

But I already add the URL database from the official website here https://supabase.com/dashboard/project/nxphroyicgnenkxwolrg/settings/database

@carlosvirreira
Copy link
Contributor

@DonKoko any idea on what could be happening to Feliciien?

@feliciien
Copy link

I try to use 'connection string' and i have this new error message Error: P1001: Can't reach database server at aws-0-eu-west-1.pooler.supabase.com:6543

Please make sure your database server is running at aws-0-eu-west-1.pooler.supabase.com:6543.
ERROR: "setup:db" exited with 1.
my question is where the server is based .

@DonKoko
Copy link
Contributor

DonKoko commented Nov 24, 2023

hey @feliciien . Seems like something is wrong with your .env file values. I remember having a similar issue when I started with supabase. I could help you further but I would need to look at your config. If you want, feel free to write me on discord and I will assist you as much as I can.

@feliciien
Copy link

can you send me your Discord username, please? @DonKoko

@DonKoko
Copy link
Contributor

DonKoko commented Nov 27, 2023

@feliciien please join our discord server here: https://discord.gg/32pUupC2 and send me a PM. You will see my there, my name is the same. You could also open a discussion in the issue-discussions channel. That way other people can help you as well.

@feliciien
Copy link

i solve the issues mentioned above now I'm focusing on the new features
Screenshot 2023-11-28 at 11 03 26 PM

@carlosvirreira
Copy link
Contributor

Nice progress @feliciien - let's ship!

@feliciien
Copy link

Hello, I want to know when I confirm if I have to create a new page for it or if I have to modify the actual page.

Screen.Recording.2023-11-30.at.7.38.52.PM.mov

@feliciien
Copy link

for follow the Figma design
Screenshot 2023-11-30 at 7 41 02 PM

@carlosvirreira
Copy link
Contributor

@jurrejansen can you assist?

@carlosvirreira
Copy link
Contributor

@feliciien for this issue, did you work on the create/edit of the PDF?

@jurrejansen
Copy link
Author

@feliciien This issue is scoped to assigning custody that requires signature. The creation of the templates documents and signing the template document are handled in other issues that are currently being worked on.

#499 Custodian electronically signs template document before receiving custody

#462 Administrators can configure PDF template documents used for assigning Custody and Bookings

@feliciien
Copy link

feliciien commented Dec 11, 2023 via email

@jurrejansen
Copy link
Author

@feliciien yes! jurrejansen

I think i already added you. Also opened a thread on the Shelf discord.

@rajdip-b
Copy link
Contributor

rajdip-b commented Dec 19, 2023

/attempt #461

Options

Copy link

algora-pbc bot commented Dec 19, 2023

Note

The user @feliciien is already attempting to complete issue #461 and claim the bounty. We recommend checking in on @feliciien's progress, and potentially collaborating, before starting a new solution.

Copy link

algora-pbc bot commented Dec 23, 2023

💡 @rajdip-b submitted a pull request that claims the bounty. You can visit your bounty board to reward.

@DonKoko
Copy link
Contributor

DonKoko commented Dec 27, 2023

  • What happens when signature is not required? I dont see the flow in the designs. Shouldn't we at least send the template via email? @jurrejansen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants