Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(location-filter): add location filter on asset index page #842

Merged
merged 4 commits into from
Mar 19, 2024

Conversation

rockingrohit9639
Copy link
Contributor

Add location filter on assets index page to filter out assets based on given location.

Fix : #841

Copy link
Contributor

@DonKoko DonKoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just placed 1 question.

app/modules/asset/service.server.ts Show resolved Hide resolved
Copy link

@jurrejansen jurrejansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rockingrohit9639 @DonKoko

So on testapp.shelf the search within the filter dropdowns kinda breaks the results after using it. And some other things.

I had presented the "Github" approach for how the dropdowns should behave on mobile. @DonKoko already told me it is quite hard to achieve this. However, any ideas of improving this is a bit so it will be a bit more usable on mobile?

RPReplay_Final1710751845.MP4

@DonKoko
Copy link
Contributor

DonKoko commented Mar 18, 2024

I had presented the "Github" approach for how the dropdowns should behave on mobile. @DonKoko already told me it is quite hard to achieve this. However, any ideas of improving this is a bit so it will be a bit more usable on mobile?

@jurrejansen for this we have to think for a general approach to implement on all of them, as this doesn't work with the current approach. I have some idea but we have to implement it.
Can you make another issue(feature request) which is about designing the dropdowns on mobile and add the designs. WE will discuss it there and find a solution

@DonKoko DonKoko merged commit 5a1d137 into Shelf-nu:main Mar 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request]: Add 'Location' filter for asset index
3 participants