-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(location-filter): add location filter on asset index page #842
feat(location-filter): add location filter on asset index page #842
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just placed 1 question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So on testapp.shelf the search within the filter dropdowns kinda breaks the results after using it. And some other things.
-
After entering a search query and then removing it, the filter shows only 6 results and the 'Show all' button doesn't work anymore
https://github.com/Shelf-nu/shelf.nu/assets/76112272/032d1428-761b-42fe-9603-4e2419d04ecb -
When a item has been selected, it doesn't have the grey background. This is working on LIVE
I had presented the "Github" approach for how the dropdowns should behave on mobile. @DonKoko already told me it is quite hard to achieve this. However, any ideas of improving this is a bit so it will be a bit more usable on mobile?
RPReplay_Final1710751845.MP4
@jurrejansen for this we have to think for a general approach to implement on all of them, as this doesn't work with the current approach. I have some idea but we have to implement it. |
Add location filter on assets index page to filter out assets based on given location.
Fix : #841