Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Environment Variables for Seed Script #858

Merged
merged 7 commits into from
Apr 1, 2024

Conversation

jugrajsingh
Copy link
Contributor

Adding a functionality that allows for overriding the email username and password in the seed script

Copy link
Contributor

@DonKoko DonKoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, however it requires also an update of the docs. Can you please update the information about the env variables in docs/getting-started so it reflects those new ones?

@jugrajsingh
Copy link
Contributor Author

This is good, however it requires also an update of the docs. Can you please update the information about the env variables in docs/getting-started so it reflects those new ones?

Updated the Getting Started Doc with the new Environment Variables

Copy link
Contributor

@DonKoko DonKoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something I noticed after further review that needs to be adjusted to fit the style of dev of shelf

app/database/seed.server.ts Outdated Show resolved Hide resolved
@DonKoko
Copy link
Contributor

DonKoko commented Mar 25, 2024

hey @jugrajsingh. I requested some changes a few days back. Can you let me know if its possible for you to do them so I know how to proceed with this PR.

@DonKoko DonKoko merged commit 286edd7 into Shelf-nu:main Apr 1, 2024
4 checks passed
@jugrajsingh jugrajsingh deleted the feature/env-for-seed-file branch May 25, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants