-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Environment Variables for Seed Script #858
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good, however it requires also an update of the docs. Can you please update the information about the env variables in docs/getting-started so it reflects those new ones?
# Conflicts: # .env.example
Updated the Getting Started Doc with the new Environment Variables |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something I noticed after further review that needs to be adjusted to fit the style of dev of shelf
hey @jugrajsingh. I requested some changes a few days back. Can you let me know if its possible for you to do them so I know how to proceed with this PR. |
Adding a functionality that allows for overriding the email username and password in the seed script