Fixing sentry errors #886
Merged
Fixing sentry errors #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ses where the image delete fails (traceId: caqwmv994p5h4c47b1vr8jux) but I couldn't recreate it when deleting an asset. The best assumption is that this happened because the regex didn't handle url params
DonKoko
commented
Mar 27, 2024
| @@ -217,6 +217,8 @@ export async function createUser( | |||
| organizationIds.push(organizationId); | |||
| } | |||
|
|
|||
| // @TODO this is weird and organizationIds is not used | |||
There was a problem hiding this comment.
Hey @mahendraHegde. We are having some bugs with the invitations and some other registration cases. I found this code in createUser that i found kinda confusing. Could you check the comment and try to remember what was the reason behind this? I want to improve it to iron out some bugs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing some errors from sentry.