made main-navigation-sidebar responsive #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonKoko
requested changes
Apr 28, 2023
There was a problem hiding this comment.
Overall it looks and works good @hunar1312. I really like it.
Just 1 thing, I see you have used the same atom to control the "keep opened" on desktop and the mobile menu. This works but I would rather use different atoms for it for a few reasons:
- I want the default state to be 'open' which only makes sense on desktop and if we do it like this, on mobile the menu will be open by default and we dont want that.
- In the near future when we add some functionality to save this in the user settings, we will again have a conflicts with that.
DonKoko
reviewed
Apr 28, 2023
DonKoko
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @DonKoko,
The desktop main navigation sidebar is now responsive for all screen sizes as described in the issue #91
Please Review this. Thanks