Manually update GPS location of asset #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-asset-gps-location
- Added a component that requests geoLocation coordinates and manually creates a scan to record the current position - Update asset/actions-dropdown to have the 'Update GPS coordinates' action - Added a new migration that adds a flag called manuallyGenerated to Scan model - Updated useFetcherWithReset hook. Removed the spread of fetcher as it might cause issues - Updated the createScan service function to take latitude, longitude and manuallyGenerated props - Created endpoint /api/asset/scan which allows to create a scan for a certain asset, using a POST request
DonKoko
changed the title
- Updated Last position details header - Added row to display the source of data (manual or scan) including a explanation tooltip - updated parseScanData to also include manuallyGenerated
|
@carlosvirreira @jurrejansen this is being deployed to testapp: https://github.com/Shelf-nu/shelf.nu/actions/runs/8798728248 and ready for testing |
|
@DonKoko Functionality wise I can't find anything. Just some front-end things.
https://github.com/Shelf-nu/shelf.nu/assets/76112272/fcd3667f-d4d4-4532-a54f-a63ceefd4ee0
|
…-asset-gps-location
…-asset-gps-location
…e them more consistent
This we should create a separate issue for so we can solve it properly and everywhere. The other point is solved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General updates:
Front-end updates: