Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fix icons used in menu items for dropdown menu's #931

Merged
merged 15 commits into from
Apr 26, 2024

Conversation

Bhavyajain21
Copy link
Contributor

/fixes #925
/claim #925

image

Copy link
Contributor

@DonKoko DonKoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes required based on our discussion on discord.

Copy link
Contributor

@DonKoko DonKoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments added on files.
Also can you please update the menu-items.tsx file to use this new method.

app/components/assets/actions-dropdown.tsx Outdated Show resolved Hide resolved
app/components/icons/WrapIcon.tsx Outdated Show resolved Hide resolved
app/components/icons/WrapIcon.tsx Outdated Show resolved Hide resolved
@Bhavyajain21
Copy link
Contributor Author

Made the changes accordingly!

@DonKoko DonKoko merged commit 806534d into Shelf-nu:main Apr 26, 2024
4 checks passed
@Bhavyajain21 Bhavyajain21 deleted the feat/fix-icons-used branch May 31, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement request]: Fix icons used in menu items for dropdown menu's
2 participants