Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Filters component #951

Merged
merged 4 commits into from
May 2, 2024
Merged

Refactor Filters component #951

merged 4 commits into from
May 2, 2024

Conversation

rockingrohit9639
Copy link
Contributor

  • remove Form from Filters and implement search as you type in SearchForm

DonKoko
DonKoko requested changes May 2, 2024
View reviewed changes
Copy link
Contributor

@DonKoko DonKoko left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 things:

  • we need to make the loading indicator work as soon as you start typing
  • i think 800ms for debounce is too long. Wouldn't 100ms be enough?

@DonKoko DonKoko merged commit c927675 into Shelf-nu:main May 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DonKoko DonKoko DonKoko requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rockingrohit9639 @DonKoko