Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work with recent pyshark #16

Closed
gador opened this issue Nov 1, 2022 · 1 comment · Fixed by #17
Closed

Does not work with recent pyshark #16

gador opened this issue Nov 1, 2022 · 1 comment · Fixed by #17

Comments

@gador
Copy link

gador commented Nov 1, 2022

Since version 0.5 from pyshark, the layer attribute has been refactored (corresponding PR). This breaks CredSLayer :

>     from credslayer.core import manager
>   File "/nix/store/69wa5yn50jr3wsw8072zrbqpksxsl0x5-credslayer-0.1.2/lib/python3.10/site-packages/credslayer/core/manager.py", line 14, in <module>
>     from credslayer.parsers import parsers, ntlmssp
>   File "/nix/store/69wa5yn50jr3wsw8072zrbqpksxsl0x5-credslayer-0.1.2/lib/python3.10/site-packages/credslayer/parsers/__init__.py", line 17, in <module>
>     module = import_module("credslayer.parsers." + module_name)
>   File "/nix/store/fkcl1wzq3106qqgl84bhgk1lp56q6bzg-python3-3.10.7/lib/python3.10/importlib/__init__.py", line 126, in import_module
>     return _bootstrap._gcd_import(name[level:], package, level)
>   File "/nix/store/69wa5yn50jr3wsw8072zrbqpksxsl0x5-credslayer-0.1.2/lib/python3.10/site-packages/credslayer/parsers/ldap.py", line 2, in <module>
>     from pyshark.packet.layer import Layer
> ModuleNotFoundError: No module named 'pyshark.packet.layer'
@ShellCode33
Copy link
Owner

Hey, thanks for reporting it. It should be fixed now. I published a new GitHub release as well as a PyPi release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants