upgrade dependencies and sbt - scala 3 support #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjfanning
changed the title
|
The latest MR code allows the tests to run with this command: Not great for a akka-rabbitmq but progress still. |
poohsen
pushed a commit
that referenced
this pull request
Nov 3, 2021
* Fully qualified the package directory structures as com.newmotion... * Merged PR #66 with Scala 3 compatibility changes * Cleaned up many warning messages that were found with IntelliJ 2021.2 * Updated the Prop constructors * Updated deprecated setTimer() calls to startSingleTimer() in ConnectionActor.scala * Upgraded to Scala 2.13.6 * Upgraded to SBT 1.5.5 and cleaned deprecated issues * Updated to latest dependencies: ** ampq-client: 5.9.0 -> 5.13.1 ** com.typesafe .config: 1.4.0 -> 1.4.1 ** org.specs2.specs2-mock: 4.10.3 -> 4.13.0 Co-authored-by: PJ Fanning <pjfanning@users.noreply.github.com>
|
was merged with #67 |
|
@pjfanning I realize now that by squashing PR #67 which contained the changes from this PR I made your contribution less visible (it's in the full text for the commit at the bottom) in the git history for this library. My apologies for that. |
|
@poohsen no worries - I'm not worried about the fact the 67 merge was squashed - thanks for merging the changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started off by seeing if akka-rabbitmq would compile with the newly published akka jars for scala 3 but it looks like there are a number of issues - still thought it would be useful to upgrade some other libs