TwoParagraphBlock: Update styling for Volunteer page variant. #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes include: - Allow for a white background (via theme prop) - Making the image span both rows for the Volunteer page variant - Eliminating the "first paragraph" <div> if no paragraph1 is passed in - Removing unnecessary differences between the Volunteer page and About Us page variants of the components There's still a bit of oddness due to differences in the design between the About Us and the Volunteer pages, but this isn't adding any further discrepancies.
richardxia
requested review from
jessica-px,
davidagustin,
candywang and
ivanleeswe
davidagustin
approved these changes
Jan 10, 2022
|
|
||
| .image1Wrapper { | ||
| margin-bottom: -142px; | ||
| @media (--laptop-and-up) { |
There was a problem hiding this comment.
Ahh I see, very clever here actually.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #271.
The changes include:
<div>if no paragraph1 is passed inUs page variants of the components
There's still a bit of oddness due to differences in the design between
the About Us and the Volunteer pages, but this isn't adding any further
discrepancies.
Since the CSS for this component is pretty tricky and there are significant differences in styling between the About Us page and Volunteer page versions, I manually checked both pages on both laptop and mobile sized screens, just to make sure there weren't any issues. Here are a few screenshots of what this now looks like:
About Us
Volunteer