Cleanup of sample scripts and operator extension #480
Conversation
| import gremlin.scala.GremlinScala | ||
| import io.shiftleft.semanticcpg.language.Steps | ||
|
|
||
| class ArithmeticTrav(raw: GremlinScala[nodes.Arithmetic]) extends Steps[nodes.Arithmetic](raw) {} |
There was a problem hiding this comment.
Can this class be deleted?
|
|
||
| import io.shiftleft.codepropertygraph.generated.nodes | ||
|
|
||
| class Arithmetic(val call: nodes.Call) extends AnyRef {} |
There was a problem hiding this comment.
Ditto - is there any reason to have an empty class? The extends AnyRef can also be dropped as it is implicit.
| @@ -4,12 +4,10 @@ import io.shiftleft.codepropertygraph.generated.nodes | |||
| import io.shiftleft.semanticcpg.language._ | |||
| import io.shiftleft.semanticcpg.language.types.expressions.Identifier | |||
|
|
|||
| class ArrayAccess(node: nodes.Call) { | |||
| class ArrayAccess(val call: nodes.Call) extends AnyRef { | |||
There was a problem hiding this comment.
Ditto w/ the AnyRef. There are a few others below, too.
| implicit def arrayAccessToCall( | ||
| node: operatorextension.nodes.ArrayAccess): io.shiftleft.semanticcpg.language.nodemethods.CallMethods = | ||
| node.call | ||
| implicit def toOpsAstNodeTrav2[NodeType <: nodes.AstNode]( |
There was a problem hiding this comment.
Might be worth dropping the 2 in the name, I'm not too sure what it means here!
|
Concerning empty classes: they are not entirely empty, they do have that |
ArrayAccess