-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to Mir Algorithm and new features #2
Comments
OK. I will try them. I do not think that exception handling is
difficult if it is only for arg type conversion error. It can be done as
follows
1. return structure with invalid arg 1-origin index and pybuffer error code from @pybuffer generated D function
2. raise TypeError with useful info and message like "invalid argment at
5th: {errcode}" instead of writeln from pybuffer.CDLL class
I think there has been much better exception handling approach between
python and C++. Maybe I will look inside pytorch, numpy and some famous C++
based python lib.
2018年9月11日(火) 0:00 Ilya <notifications@github.com>:
… Would you mind to move mir-pybuffer to mir-algorithm?
Feature request:
- scalar D types (numbers, chars, strings) to PyObject wrap (so, no
need use ctypes at python side for numeric args). The idea that wrapper
accept PyObject on D side and decide if it can be converted to a scalar
type.
- exceptions instead of errors on python side (if possible), plus no
writeln for errors.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AGbs7pEReFd0A2w3r1yx7AaLkeBuyMFBks5uZn6rgaJpZM4WhlZ7>
.
|
Scalar support and moving mir-algorithm are no problem. I appreciate it |
@9il I'm reworking this by using Python C API and BP in new repository https://github.com/ShigekiKarita/mir-pybind |
Nice, ping me when it ready for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Would you mind to move mir-pybuffer to mir-algorithm?
Feature request:
writeln
for errors.The text was updated successfully, but these errors were encountered: