Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: using error log instead of errorf #39

Merged
merged 2 commits into from
Oct 10, 2023
Merged

chore: using error log instead of errorf #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ebca502
chore: using error log instead of errorf
ShiningRush Oct 9, 2023
2c94594
chore: add more time for test
ShiningRush Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/mod/dispatcher_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ func TestDefDispatcher_InitAndClose(t *testing.T) {
})
log.SetLogger(mLogger)
d.Init()
time.Sleep(time.Second)
time.Sleep(time.Second * 5)
d.Close()
assert.True(t, calledList, tc.caseDesc)
assert.Equal(t, calledLog, tc.wantLogCalled, tc.caseDesc)
Expand Down
2 changes: 1 addition & 1 deletion pkg/mod/parser.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,7 +512,7 @@
}

func (p *DefParser) handleErr(err error) {
log.Errorf("parser get some error",
log.Error("parser get some error",

Check warning on line 515 in pkg/mod/parser.go

View check run for this annotation

Codecov / codecov/patch

pkg/mod/parser.go#L515 

Added line #L515 was not covered by tests
"module", "parser",
"err", err)
}
Loading