New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add css-(un)escape, allow using escaped selectors #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shinmera
requested changes
Jul 27, 2022
Should be all addressed now:
|
The new one lets NIL through.
I've introduced some index-out-of-bounds mistakes while refactoring, they should be fixed now :P |
Shinmera
reviewed
Jul 28, 2022
Shinmera
reviewed
Jul 28, 2022
Looks good (save for not upcasing |
Ahhhh, right, I'm always forgetting about this stylistic convention of yours 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds:
css-escape
, API akin to CSS.escape()) and parse escaped ones back to literal values (css-unescape
, a naïve reverse ofcss-escape
).clss-name
syntax rule to allow backslash-escaped characters (should it be#x1F
to#xFF
, actually? I've included all of ASCII just in case...)All in all, it fixes #13 (if you use
css-escape
on the class name) and allows for a safer and more reliable element selection.@Shinmera, I've tried to optimize the hell out of
css-escape
andcss-unescape
, but I may have missed some important nit. For instance, how do you specify the element type of a string -- it should be character, right? SBCL complains about it being unspecified :/