Fixed Linting errors

ShipEngine · Nov 12, 2020 · 84042d6 · 84042d6
1 parent 96a071f
commit 84042d6
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/src/core/test-app/utils/use-domestic-shipment-addresses.ts b/src/core/test-app/utils/use-domestic-shipment-addresses.ts
@@ -7,7 +7,7 @@ import { buildAddressWithContactInfo } from "../factories/address";
 export default function useDomesticShippingAddress(
   deliveryService: DeliveryService,
 ): [AddressWithContactInfoPOJO | undefined, AddressWithContactInfoPOJO | undefined] {
-  let country: string | undefined = deliveryService.availableCountries.find(country => buildAddressWithContactInfo(`${country}-from`) && buildAddressWithContactInfo(`${country}-to`));
+  const country: string | undefined = deliveryService.availableCountries.find(country => buildAddressWithContactInfo(`${country}-from`) && buildAddressWithContactInfo(`${country}-to`));
   return [
     buildAddressWithContactInfo(`${country}-from`),
     buildAddressWithContactInfo(`${country}-to`),

diff --git a/src/core/test-app/utils/use-international-shipment-addresses.ts b/src/core/test-app/utils/use-international-shipment-addresses.ts
@@ -8,8 +8,8 @@ export default function useInternationalShipmentAddresses(
   deliveryService: DeliveryService,
 ): [AddressWithContactInfoPOJO, AddressWithContactInfoPOJO] {
   const allCountries = Object.values(Country);
-  let originCountryCode: string | undefined = deliveryService.availableCountries.find(country => buildAddressWithContactInfo(`${country}-from`));
-  let destinationCountryCode: string | undefined = allCountries.find(country => country !== originCountryCode && buildAddressWithContactInfo(`${country}-to`));
+  const originCountryCode: string | undefined = deliveryService.availableCountries.find(country => buildAddressWithContactInfo(`${country}-from`));
+  const destinationCountryCode: string | undefined = allCountries.find(country => country !== originCountryCode && buildAddressWithContactInfo(`${country}-to`));
 
   if(!originCountryCode || !destinationCountryCode) {
     throw new Error(`useInternationalShipmentAddresses error. Unable to find address in ${deliveryService.availableCountries}`);

diff --git a/src/core/test-app/utils/use-shipment-addresses.ts b/src/core/test-app/utils/use-shipment-addresses.ts
@@ -13,8 +13,7 @@ export default function useShipmentAddresses(deliveryService: DeliveryService):
   if(deliveryService.serviceArea === ServiceArea.Global || deliveryService.serviceArea === ServiceArea.International) {
     const internationalAddress = useInternationalShipmentAddresses(deliveryService);
     return internationalAddress;
-  } else {
-    const domesticAddress =  useDomesticShippingAddress(deliveryService);
-    return domesticAddress;
   }
+  const domesticAddress =  useDomesticShippingAddress(deliveryService);
+  return domesticAddress;
 }