Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support for placementStrategy and placementConstraints #4406

Open
efeller opened this issue Jun 18, 2018 · 3 comments
Open

Improve support for placementStrategy and placementConstraints #4406

efeller opened this issue Jun 18, 2018 · 3 comments

Comments

@efeller
Copy link

efeller commented Jun 18, 2018

We are trying to use placementStrategy field in dockerOptions and it does not seem to work. No problems in the build:

https://app.shippable.com/github/zenreach/jobs/sightings-zp-phantom/builds/5b280a17fbb9510700f4ce9e/console

However, the resulting service on AWS ECS does not have a task placement strategy set. Under the deployments section it simply says:

Strategy No strategies

@efeller
Copy link
Author

efeller commented Jun 18, 2018

This might be working. However, it needs a destroy of the job on ECS and a redeploy via shippable with a reset. Can you please fix it such that I can add placementStrategy without a job delete and redeploy?

Thanks

@trriplejay
Copy link

@efeller yeah, this is the behavior of ECS itself. Internally, we would still have to delete/redeploy the service. Is that the behavior you would want? (similar to what happens when changing a load balancer)

@efeller
Copy link
Author

efeller commented Jun 20, 2018

@trriplejay Yea, it would be fine if shippable did the delete/redeploy for me. Thanks.

@manishas manishas changed the title Unable to use placementStrategy Improve support for placementStrategy and placementConstraints Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants