-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gitRepo resource getting new versions when it shouldn't #4477
Comments
the "branch" defined in the versionTemplate governs which webhooks it pays attention to, however since your resource is only updated via I don't think there's any way to avoid this right now. I'll open a feature request to have replicate follow branch settings. If this is critical, i think we could come up with a script workaround that manually performs the same actions that a |
It would be great if we could have such a script until this feature is in place. Right now our pipeline is pushing untested code into production. Would it be possible to schedule a meeting with you and do a review of our setup? I feel like we might be doing something wrong - or at least using your features in unintended ways. Using Shippable in idiomatic ways might help us run into less issues than we are right now. |
We can do a meeting and go over your setup... what time zone are you in? Let me know a few times that work and we can get that set up. |
I am in CEST. I can pretty much have a meeting at any time between 9pm and 12pm my time. The sooner the better. |
Hi? |
@oyving can you clarify the time slots that work for you again? We're in PST. |
Alright. Let us set up a call at 8am tomorrow CEST. That should be around 11pm today your time. We can use https://appear.in/aia-shippable to discuss the matter. Please confirm. |
@oyving I need a little more lead time to set up a call with the team. Can I get your email address so I can send over a couple of times that work for us? We can coordinate over email. My email is manisha@shippable.com |
Hi @oyving , we've just released a feature that will help you accomplish what you want. The steps to utilize it for your scenario look like this:
What this will do is compare the branch settings of the OUT to the shaData of the IN. If the IN commit was for a branch that the OUT is not configured to watch, then the replicate will not happen. In your example, the OUT would only be updated if the IN was processing a commit to master. You can find more information about the replicate command here: http://docs.shippable.com/platform/tutorial/workflow/using-shipctl/#replicate |
We have a few
gitRepo
resources defined as follows:These resources are
OUT
for somerunSh
jobs and act asIN
for jobs further downstream. The intended effect is that ourrunCI
job will buildmaster
branch, and on success publish a version and git state for the other jobs to use.However, we are seeing these
gitRepo
resources being triggered even when we are not making commits to themaster
branch. Is there a bug or did we misunderstand something?The text was updated successfully, but these errors were encountered: