Implementing HISTORY_GAMESTATE_REPLCIATED_TIME_AS_DOUBLE #46
Conversation
| @@ -108,6 +108,9 @@ public class GameState : INetFieldExportGroup | |||
| [NetFieldExport("ReplicatedWorldTimeSeconds", RepLayoutCmdType.PropertyFloat)] | |||
| public float? ReplicatedWorldTimeSeconds { get; set; } | |||
|
|
|||
| [NetFieldExport("ReplicatedWorldTimeSecondsDouble", RepLayoutCmdType.PropertyDouble)] | |||
There was a problem hiding this comment.
Is/was that property really named ReplicatedWorldTimeSecondsDouble?
I thought it replaced ReplicatedWorldTimeSeconds with a breaking change.
There was a problem hiding this comment.
Yes, going forward there will only be ReplicatedWorldTimeSecondsDouble in the replays. However, old replays will still have ReplicatedWorldTimeSeconds which is a different datatype.
Options:
1: keeping both (current PR)
2: keep ReplicatedWorldTimeSeconds, and cast the new property from double to float
3: keep ReplicatedWorldTimeSecondsDouble and cast the old property from float to double (will break old code that uses this repo)
4: replace ReplicatedWorldTimeSeconds with ReplicatedWorldTimeSecondsDouble (new versions of this repo won't be able to parse old replays)
It's tricky, I think option 4 is the worst, at least for me I'm parsing old replays as well. It's your call, just let me know and I'll do it.
For backwards compatibility I created a new double variable.