Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of the previous KMeans instance #7

Closed
mateusz-politycki-wttech opened this issue Sep 9, 2022 · 1 comment
Closed

Use of the previous KMeans instance #7

mateusz-politycki-wttech opened this issue Sep 9, 2022 · 1 comment

Comments

@mateusz-politycki-wttech

I wonder if using the previous KMeans instance at this point is intentional. I mean the part_algorithm was trained on normalized_all_fg_sampled_descriptors as opposed to common_part_algorithm, which is trained on normalized_all_common_sampled_descriptors.

_, common_part_labels = part_algorithm.index.search(normalized_all_common_descriptors.astype(np.float32), 1)

ShirAmir added a commit that referenced this issue Sep 9, 2022
fixed the third kmeans inference to be on the third trained kmeans instead of the second one.
Thanks to #7 for pointing out the issue.
@ShirAmir
Copy link
Owner

ShirAmir commented Sep 9, 2022

Hi @mateusz-politycki-wttech, thanks for pointing out the issue! it is indeed a bug.
it has been fixed and updated in the repo.

Due note that we recommend using the three stage version only on small sets.

@ShirAmir ShirAmir closed this as completed Sep 9, 2022
anuragg1209 pushed a commit to gopaljigaur/task-detection-project that referenced this issue Jun 16, 2023
fixed the third kmeans inference to be on the third trained kmeans instead of the second one.
Thanks to ShirAmir/dino-vit-features#7 for pointing out the issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants