Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR for Gradio WebUI Feature ([feature] Gradio webui - #102) #105

Merged
merged 3 commits into from
Aug 22, 2023

Conversation

TanmayDoesAI
Copy link
Contributor

The WebUI implementation is progressing well. I'm currently in the process of adding the model selection dropdown, per your suggestion. However, handling the varied output styles of different models is taking a bit longer than anticipated due to the need for regex customization. Rest assured, I'm diligently working on this aspect.

Just making this available so that this is accessible to people as early as possible. Will get the other parts done soon!

Also had to ask do I upload the python notebook to the repository too?

@ShishirPatil
Copy link
Owner

Hey @TanmayDoesAI thanks for raising this PR! Some minor comments,

  1. Re [feature] Gradio webui #102 did you get a chance to add a radio button/dropdown where the user can pick from the Gorilla models?
  2. For the gradio image, maybe good to have a png of the prompt + gradio output?
  3. Also, do you mind giving me edit permissions for the colab? So I can add some more documentation and clean it up. I could also make a copy of the colab and share that, but I want to acknowledge your work, and make sure you have control / the final word 🙂

Thanks!

@TanmayDoesAI
Copy link
Contributor Author

  1. I am working towards it, sir, just had gotten occupied with something, else will be ready soon.
  2. I didn't really get understood what you wish convey here, maybe we could have a chat on discord if that would work, whatever time you see fit, I am in UTC+5:30 and my username is Tanmayy( I am in the Gorilla LLM server too)
  3. For sure sir, I would give you the access straightaway, could you share your email (over discord itself if not in public here, whatever is comfortable)?

Copy link
Owner

@ShishirPatil ShishirPatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great work proposing the feature in #102 and landing the PR so quickly @TanmayDoesAI 🚀

@ShishirPatil ShishirPatil merged commit b5c5313 into ShishirPatil:main Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants