Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove replace_llama_attn_with_non_inplace_operations as we don't supported it yet #19

Conversation

tianjunz
Copy link
Collaborator

@tianjunz tianjunz commented May 29, 2023

Ref: #18
We haven't added support for Apple's MPS for inference. Contributions welcome!

tianjunz and others added 2 commits May 29, 2023 13:33
… supported it yet

We haven't added support for `replace_llama_attn_with_non_inplace_operations`, so just remove it for now
Remove `mps` device checking
@ShishirPatil ShishirPatil changed the title remove replace_llama_attn_with_non_inplace_operations as we haven't… remove replace_llama_attn_with_non_inplace_operations as we don't supported it yet May 29, 2023
Copy link
Owner

@ShishirPatil ShishirPatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShishirPatil ShishirPatil merged commit d7e01d5 into main May 29, 2023
@ShishirPatil ShishirPatil deleted the remove-`replace_llama_attn_with_non_inplace_operations`-as-we-haven't-supported-it-yet branch May 29, 2023 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants