Add Support for NousResearch/Hermes-2-Pro-Mistral-7B Function Calling #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
CharlieJCJ
suggested changes
Apr 8, 2024
There was a problem hiding this comment.
@Fanjia-Yan Can you add the model in README table, and add an entry in changelog linked to the current PR? Thanks
CharlieJCJ
reviewed
Apr 9, 2024
ShishirPatil
pushed a commit
that referenced
this pull request
Apr 14, 2024
…ro-Mistral-7B (#346) As mentioned in #327, this PR updates the leaderboard with the new model Hermes-2-Pro-Mistral-7B. This PR **does** change the value on the leaderboard. Specifically, it adds a new entry; it does not change the score for any of the existing models. The previous PR #328 was closed by accident.
ShishirPatil
pushed a commit
that referenced
this pull request
Apr 14, 2024
devanshamin
pushed a commit
to devanshamin/gorilla
that referenced
this pull request
Jul 9, 2024
…ShishirPatil#327) This PR introduces support for [ NousResearch/Hermes-2-Pro-Mistral-7B](https://huggingface.co/NousResearch/Hermes-2-Pro-Mistral-7B). Specifically, it includes: - The implementation of a function calling system prompt passing in OpenAI compatible JSON function descriptions, as detailed on the Huggingface model page. - The ability to parse raw Hermes output into a standard {"name": ..., "arguments": ...} dictionary format. - A refactoring of `oss_handler.py` to specify `test_category` during the VLLM batch generation process. This enables special handling for function JSON parameter types in the java and javascript categories. This PR will result in changes to the leaderboard by adding an entry for one model. The PR that makes changes to the leaderboard webpage is linked here [PR](ShishirPatil#328). --------- Co-authored-by: CharlieJCJ <charliechengjieji@berkeley.edu> Co-authored-by: Huanzhi Mao <huanzhimao@gmail.com>
devanshamin
pushed a commit
to devanshamin/gorilla
that referenced
this pull request
Jul 9, 2024
This PR fixed a circular import issue introduced by the merging of ShishirPatil#327 and ShishirPatil#318. This PR is just a bug-fix PR, and will not affect the BFCL leaderboard score.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for NousResearch/Hermes-2-Pro-Mistral-7B. Specifically, it includes:
oss_handler.pyto specifytest_categoryduring the VLLM batch generation process. This enables special handling for function JSON parameter types in the java and javascript categories.This PR will result in changes to the leaderboard by adding an entry for one model. The PR that makes changes to the leaderboard webpage is linked here PR.